Remove workaround for bug triggered by Android environment variable#246
Draft
finagolfin wants to merge 1 commit intoswiftlang:mainfrom
Draft
Remove workaround for bug triggered by Android environment variable#246finagolfin wants to merge 1 commit intoswiftlang:mainfrom
finagolfin wants to merge 1 commit intoswiftlang:mainfrom
Conversation
We had to unset this common Android env var to work around the compiler bug, but it should be fixed in the compiler now.
Member
Author
|
This should be fixed in trunk and will be in the next 6.3 snapshot or release, so getting this cleanup ready for that. |
Member
Author
|
@marcprux, mind adding a 6.3 release option for Android in this CI sometime today? I'm about to doze off. 😴 |
Contributor
|
@finagolfin Can we get this merged? |
Member
Author
|
The last 6.3 snapshot didn't have the env var fix you approved in swift-driver, so I am waiting for the next 6.3 nightly snapshot to be tagged before merging this, else this will still break Since unsetting this env var should have no effect on 6.3 and trunk, I'm leaving this workaround in until all three 6.3 and 6.4 builds have the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had to unset this common Android env var to work around the compiler bug, but it should be fixed in the compiler now.